Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly broken dependency detection #8

Open
joepie91 opened this issue Sep 14, 2017 · 2 comments
Open

Possibly broken dependency detection #8

joepie91 opened this issue Sep 14, 2017 · 2 comments
Assignees
Labels

Comments

@joepie91
Copy link

I had a look at the dependency detection logic, and if my reading of the code is correct, it could produce false positives.

For example, given a check for the libz entry, it would check for the path $usr_path/lib/libz*, which means that even if no libz.so or similar existed, something like libzanzibar.so (which would be an entirely different library!) would still match, and therefore the script would incorrectly presume that libz is installed.

My Bash is a little rusty so I'm unsure whether this assessment is correct, but if it is, then a fix would probably be to do something like the following instead (note the dot at the end):

so_files="$usr_path/lib/$so."*
@Zapotek
Copy link
Member

Zapotek commented Sep 19, 2017

Good catch, I'll have a look.

Cheers

@Zapotek Zapotek added the bug label Sep 19, 2017
@Zapotek Zapotek self-assigned this Sep 19, 2017
@Zapotek
Copy link
Member

Zapotek commented Nov 1, 2017

That doesn't seem to work with Postgres and Ruby libs and since there currently aren't any conflicts I'm not worried.
I'll leave this open though as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants