diff --git a/pkg/runtime/store/core.go b/pkg/runtime/store/core.go index e35838a6..a1546022 100644 --- a/pkg/runtime/store/core.go +++ b/pkg/runtime/store/core.go @@ -28,7 +28,6 @@ type Policy interface { // Revision represents database operations for Revision object type Revision interface { GetRevision(gen runtime.Generation) (*engine.Revision, error) - GetFirstRevisionForPolicy(policyGen runtime.Generation) (*engine.Revision, error) GetLastRevisionForPolicy(policyGen runtime.Generation) (*engine.Revision, error) GetAllRevisionsForPolicy(policyGen runtime.Generation) ([]*engine.Revision, error) NewRevision(policyGen runtime.Generation) (*engine.Revision, error) diff --git a/pkg/runtime/store/core/revision.go b/pkg/runtime/store/core/revision.go index 78e94268..e86e4206 100644 --- a/pkg/runtime/store/core/revision.go +++ b/pkg/runtime/store/core/revision.go @@ -24,30 +24,6 @@ func (ds *defaultStore) GetRevision(gen runtime.Generation) (*engine.Revision, e return data, nil } -// GetFirstRevisionForPolicy returns first revision for specified policy generation in chronological order -func (ds *defaultStore) GetFirstRevisionForPolicy(policyGen runtime.Generation) (*engine.Revision, error) { - // TODO: this method is slow, needs indexes - revisionObjs, err := ds.store.ListGenerations(engine.RevisionKey) - if err != nil { - return nil, err - } - - var result *engine.Revision - for _, revisionObj := range revisionObjs { - revision := revisionObj.(*engine.Revision) - - if revision.Policy != policyGen { - continue - } - - if result == nil || revision.GetGeneration() < result.GetGeneration() { - result = revision - } - } - - return result, nil -} - // GetLastRevisionForPolicy returns last revision for specified policy generation in chronological order func (ds *defaultStore) GetLastRevisionForPolicy(policyGen runtime.Generation) (*engine.Revision, error) { // TODO: this method is slow, needs indexes