Fix resuming crafting recipe jobs after a world load #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay but why is it using the hashCode at all? 🤔 |
|
Considering this is a |
Yes it does, but Mithi is right in that the record contains ItemStack children which do not correctly implement hashCode/equals |
|
I checked Vanillas "BundleContents" data component, and they are also implementing a custom equals/hashCode.
|
The ItemStack type used in EncodedCraftingPattern provides no hashCode() function and is thus not usable in hashCode() functions of objects containing it. This leads to an effect where a running job using an EncodedCraftingPattern does not resume after loading the world. Providing an explicit hashCode() function for EncodedCraftingPattern solves this problem. Fix AppliedEnergistics#8006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ItemStack type used in EncodedCraftingPattern provides no hashCode() function and is thus not usable in hashCode() functions of objects containing it.
This leads to an effect where a running job using an EncodedCraftingPattern does not resume after loading the world. Providing an explicit hashCode() function for EncodedCraftingPattern solves this problem.
Fix #8006.