Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view cell are still visible on small enough gui scales #7998

Open
Mari023 opened this issue Jul 1, 2024 · 3 comments
Open

view cell are still visible on small enough gui scales #7998

Mari023 opened this issue Jul 1, 2024 · 3 comments

Comments

@Mari023
Copy link
Contributor

Mari023 commented Jul 1, 2024

image with gui scale 1 on a 1080p screen:
2024-07-01_03 14 14

@Mithi83
Copy link
Contributor

Mithi83 commented Jul 1, 2024

In 4k gui scale 2 is affected as well.

@Mithi83
Copy link
Contributor

Mithi83 commented Jul 2, 2024

Isn't the real bug though that the view cell slots are invisible in lower resolutions or with higher gui scale settings? This functionality is not accessible to the player otherwise. From the looks of it the view cells should probably be attached to the right side of the terminal. I played around a bit an setting "right" to "2" instead of "800" in src/main/resources/assets/ae2/screens/terminals/base_terminal.json looks pretty decent unless the scroll bar is shorter than the view cell section height.

@Ridanisaurus probably knows best what the intentions were when he moved that away during retexturing.

@Ridanisaurus
Copy link
Contributor

The ViewCells were moved away temporarily until they are implemented inside the settings page if I recall correctly. I think once that's done they should be removed completely from the BaseScreenGUI.
@shartte is better equipped to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants