Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mobile Selection doesn't support long press #568

Open
robinjhuang opened this issue Oct 30, 2023 · 7 comments
Open

[Bug] Mobile Selection doesn't support long press #568

robinjhuang opened this issue Oct 30, 2023 · 7 comments
Assignees

Comments

@robinjhuang
Copy link

Bug Description

I ran the library under examples on an ios Simulator and local ios Device.

Expected behavior: Long press anywhere on the editor should open a "Select All | Select" pop up. Dragging in the editor should select all the text in the drag action. This is how native ios TextFields work.

Actual Behavior: You can only select text by double tapping.

Is this the desired behavior? Do I need to do anything special to achieve the "Expected behavior" above?

Thanks for the great work! Opening this to clarify something I haven't been able to figure out.

How to Reproduce

Open iOS simulator.

cd examples/lib
flutter run 

Click mouse, holding it and drag across some text.

Expected Behavior

Expecting the text to be selected on drag but it's not.

Operating System

ios

AppFlowy Editor Version(s)

1.5.0

Screenshots

No response

Additional Context

No response

@LucasXu0 LucasXu0 self-assigned this Nov 6, 2023
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Nov 6, 2023

Long press anywhere on the editor should open a "Select All | Select" pop up.

@robinjhuang tap at the same position twice will trigger the toolbar.

Expecting the text to be selected on drag but it's not.

I can't reproduce it. Do you mean that you can't select the text by dragging the handler?

@robinjhuang
Copy link
Author

robinjhuang commented Nov 6, 2023 via email

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Nov 6, 2023

The editor supports text selection by dragging the handlers. Is this what you want, just like the video shows?

drag.mp4

@robinjhuang
Copy link
Author

Very close. I wish the AdaptiveTextSelectionToolbar would appear even when you press on a section without selected text. If you want to paste something for example.

Untitled.mp4

@alihassan143
Copy link
Contributor

alihassan143 commented Nov 21, 2023

@LucasXu0 longpress on text and start dragging this is not supported by the appflowy editor

@annieappflowy
Copy link
Collaborator

Hi @robinjhuang and @alihassan143 , we're eager to gather valuable feedback from our users to better plan for 2024. Participants who complete this survey will gain priority access to our new launches. We appreciate your insights: https://tally.so/r/nW8qAQ.

@armandsLa
Copy link

Looks like this issue is related:
#667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants