Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dev Scripts cause flutter version reset #1912

Closed
AmanNegi opened this issue Mar 3, 2023 · 3 comments
Closed

[Bug] Dev Scripts cause flutter version reset #1912

AmanNegi opened this issue Mar 3, 2023 · 3 comments

Comments

@AmanNegi
Copy link
Contributor

AmanNegi commented Mar 3, 2023

Issue

When we setup our environment using the install_dev_env files, it causes the Flutter Version to reset to the latest stable one. This behavior should be improved as we are using the specific version v3.3.10 and any other version would cause error in the building process.

Caused By

I was able to narrow down the cause of error as the following lines in the install_dev_env files:

# Enable the flutter stable channel
printMessage "Setting up Flutter"
flutter channel stable

Solutions

Simply, comment these lines and prompt the user to have the specific version at end. As anyone following the gitbook would have the right version installed. Also we are assuming here that the, flutter is added to path and is thus installed, so it makes sense to remove this line.

How to Reproduce

On your system install flutter v3.3.10, and then run the scripts provided under install_dev_env and then check your flutter version.

Expected Behavior

Do not modify pre-existing flutter version.

Operating System

Ubuntu 20.04.5 LTS

AppFlowy Version(s)

1.0.0.1

Screenshots

No response

Additional Context

No response

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 3, 2023

Let me know, if I am right on this. And I would love to comment those lines 🤣

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 3, 2023

Hey, @AmanNegi. Yes. It's right. You can submit a PR to replace them with a new command to switch to v3.3.10 version.

@AmanNegi
Copy link
Contributor Author

Hey @LucasXu0 as there are no further reports of this issue, I will be closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants