Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify multisend contract address detection #51

Closed
banteg opened this issue Jun 8, 2024 · 1 comment · Fixed by #58
Closed

simplify multisend contract address detection #51

banteg opened this issue Jun 8, 2024 · 1 comment · Fixed by #58

Comments

@banteg
Copy link
Contributor

banteg commented Jun 8, 2024

DEFAULT_ADDRESS = "0xA238CBeb142c10Ef7Ad8442C6D1f9E89e07e7761"
DEPLOYMENT_ADDRESS = {
10: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
25: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
28: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
61: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
63: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
69: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
82: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
83: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
106: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
111: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
288: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
322: "0x6367360366E4c898488091ac315834B779d8f561",
338: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
420: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
588: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
595: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
599: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
686: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
787: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
1001: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
1088: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
1294: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
7700: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
8217: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
10000: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
10001: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
42220: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
43114: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
54211: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
71401: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
71402: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
11155111: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
1666600000: "0x998739BFdAAdde7C933B942a68053933098f9EDa",
1666700000: "0x998739BFdAAdde7C933B942a68053933098f9EDa",

there are only two addresses ever. any address will do, and we can just use the first address that has code. see how it's done here:

https://github.com/safe-global/safe-eth-py/blob/ae5ebe0dee0556157bcb7c2370c3d0732e1f3e59/gnosis/safe/multi_send.py#L171-L178

another important thing is we should switch to multisend call only version because it prevents the user from accidentally corrupting safe storage with a delegatecall.

Copy link

linear bot commented Jun 8, 2024

@banteg banteg changed the title simplify multisend detection simplify multisend contract address detection Jun 9, 2024
@vany365 vany365 added the Contributor label Jun 26, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants