Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Or Fix Support for Apple and MacOS Compilation #212

Closed
ericpassmore opened this issue Aug 22, 2023 · 4 comments · Fixed by #223, #224 or #233
Closed

Remove Or Fix Support for Apple and MacOS Compilation #212

ericpassmore opened this issue Aug 22, 2023 · 4 comments · Fixed by #223, #224 or #233
Assignees
@spoonincode
Labels
triage
Milestone
CDT 4.0.1

Comments

@ericpassmore
Copy link
Contributor

ericpassmore commented Aug 22, 2023 •
edited
Loading

Investigate best approach for MacOS Builds.

  • Should we fix the existing build
    OR
  • Remove specialized code for MacOS builds.
@spoonincode
Copy link
Member

A thorough removal of macOS support may end up taking more work than trying to fix the existing macOS support. Best I could tell there is only one nagging issue -- cdt-cpp -fnative not adding the SDK's sysroot to the command line resulting in "Framework not found" errors. Granted, this may be tricky to solve, but unwinding all the various #ifdef __APPLE__s and such may not be straightforward either.

@ericpassmore
Copy link
Contributor Author

Good point, updated issue description. This isn't a high priority for us, mostly for tracking purposes, and part of our conversation for unwinding custom LLVM extensions.

@ericpassmore ericpassmore added this to the Future Milestone milestone Aug 24, 2023
@spoonincode spoonincode linked a pull request Sep 15, 2023 that will close this issue
[4.0] fix -fnative linking on macOS #223
Merged
@spoonincode spoonincode changed the title Remove Support for Apple and MacOS Compilation Remove Or Fix Support for Apple and MacOS Compilation Sep 15, 2023
@spoonincode spoonincode self-assigned this Sep 15, 2023
@spoonincode spoonincode linked a pull request Sep 16, 2023 that will close this issue
[4.0] migrate to find_package(Python) for cmake 3.27+ #224
Merged
@spoonincode
Copy link
Member

The fixes in the two linked PRs allow me to build and use cdt on latest macOS+Xcode with a M1 Mac Mini

@ericpassmore ericpassmore modified the milestones: Future Milestone, CDT 4.1.0-rc1 Sep 19, 2023
@spoonincode spoonincode linked a pull request Sep 25, 2023 that will close this issue
[4.0] remove is_callable_v<> workaround, fixing build on latest clang #233
Merged
@spoonincode
Copy link
Member

4.0.x release branch is fully operational on latest macOS & xcode, closing this

@ericpassmore ericpassmore modified the milestones: 4.0.1 Patch Release, CDT 4.0.1 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spoonincode spoonincode

Labels
triage
Projects
Team Backlog
Archived in project
Milestone
CDT 4.0.1
3 participants
@ericpassmore @spoonincode @enf-ci-bot