Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eddy tracking and python3.12 #254

Closed
ctroupin opened this issue Nov 18, 2024 · 3 comments
Closed

Eddy tracking and python3.12 #254

ctroupin opened this issue Nov 18, 2024 · 3 comments

Comments

@ctroupin
Copy link
Contributor

Hello Antoine,

I've recently restarted to use the package and surprisingly with python3.12 (in a virtual environment), I don't get the expected results: whatever domain I select, the code only detects one eddy.

For instance with the data provided with the code

g = RegularGridDataset(
    data.get_demo_path("dt_med_allsat_phy_l4_20160515_20190101.nc"),
    "longitude",
    "latitude",
)
g.add_uv("adt")
a, c = g.eddy_identification("adt", "u", "v", datetime.datetime(2016, 5, 20), 0.001, shape_error=85, pixel_limit=(1, 50000))

(note that I used a large value for shape_error and a wide interval for pixel_limit so I'm sure I find eddies) and this is what I got (the eddy is visible in green):
Screenshot from 2024-11-18 15-23-17

Then I re-installed everything from scratch, again in virtual environment, but with python3.10, and now the results are OK:
Screenshot from 2024-11-18 15-24-21

Question: is there a specific reason why it would fail with python3.12?
(and sorry if it's in the doc and I didn't see it)

@AntSimi
Copy link
Owner

AntSimi commented Nov 18, 2024

It's a known problem #217 that i didn't take time to solve, matplotlib >= 3.8 have a new object for contour that are not correctly managed by py eddy tracker.

@AntSimi
Copy link
Owner

AntSimi commented Nov 18, 2024

Recently i set matplotlib version in requirements.txt to avoid this problem, before to correctly manage the upgrade of matplotlib

@ctroupin
Copy link
Contributor Author

ok thanks, if it's known then let's close, I'll be using another Python (and matplotlib) versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants