Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter names should be reversed. #144

Open
ThinkDigitalSoftware opened this issue May 29, 2020 · 1 comment
Open

Parameter names should be reversed. #144

ThinkDigitalSoftware opened this issue May 29, 2020 · 1 comment

Comments

@ThinkDigitalSoftware
Copy link

/// The title displayed to the user
final String title;

/// The message displayed to the user.
final String message;

/// Replaces [title]. Although this accepts a [Widget], it is meant to receive [Text] or [RichText]
final Widget titleText;

/// Replaces [message]. Although this accepts a [Widget], it is meant to receive [Text] or [RichText]
final Widget messageText;

If this were to be consistent with Flutter naming schemes, we'd swap the names.
title should be a Widget, and titleText should be a String. Take InputDecoration for example.
Screen Shot 2020-05-29 at 3 48 45 PM

@mohak852
Copy link

mohak852 commented Jun 5, 2020

@AndreHaueisen can you assign this issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants