Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slice::split_at() instead of keeping track of index in Overlapping #12

Closed
Anders429 opened this issue Feb 19, 2021 · 2 comments
Closed

Use slice::split_at() instead of keeping track of index in Overlapping #12

Anders429 opened this issue Feb 19, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.3.0

Comments

@Anders429
Copy link
Owner

Overlapping iteration can use slice::split_at() instead of the current practice of keeping track of the index. This will allow it to only store the slice, and not have to worry about storing an index.
@Anders429 Anders429 added enhancement New feature or request good first issue Good for newcomers labels Feb 19, 2021
@Anders429 Anders429 added this to the 0.3.0 milestone Feb 19, 2021
@Anders429
Copy link
Owner Author

Decided to use slice::get_unchecked() instead, as that is what is used internally. The tracking issue for slice::split_at_unchecked() points out that slice::get_unchecked() can easily be used to perform an unchecked split on a slice, and there is question on whether it is even worth it to create a separate method for this purpose.

@Anders429
Copy link
Owner Author

This has been merged into 0.3.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@Anders429