Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button #8

Closed
Amndeep7 opened this issue Jul 22, 2018 · 3 comments
Closed

Button #8

Amndeep7 opened this issue Jul 22, 2018 · 3 comments
Labels
enhancement

Comments

@Amndeep7
Copy link
Owner

Add that toolbar button in order to have it pop up with any errors instead of silently failing
@Amndeep7 Amndeep7 mentioned this issue Jul 22, 2018
Open
@Amndeep7
Copy link
Owner Author

Amndeep7 commented Jul 25, 2018 •
edited
Loading

#6 is dependent on this for also being able to accept user credentials that then get passed along to kitsu

See below - this means that #6 now ought to be dependent on #16

@Amndeep7
Copy link
Owner Author

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups

However, you can't open the popup programmatically from an extension's JavaScript; it can be opened only in response to a user action.

But it looks like I can use this instead: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Notifications

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Aug 6, 2018

Satisfied with #18

@Amndeep7 Amndeep7 closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Amndeep7