From 3533e1ac1e19cf7ddae239ca243959a8015c3e6b Mon Sep 17 00:00:00 2001
From: matthieu-crouzet <matthieu.crouzet@amadeus.com>
Date: Fri, 20 Sep 2024 18:09:31 +0200
Subject: [PATCH] fix(pr-labels): reduce the time to find touched projects

---
 .../@o3r/build-helpers/scripts/pr-labels.mjs  | 46 +++++++++----------
 1 file changed, 22 insertions(+), 24 deletions(-)

diff --git a/tools/@o3r/build-helpers/scripts/pr-labels.mjs b/tools/@o3r/build-helpers/scripts/pr-labels.mjs
index 3b8f77f511..1abd0177ad 100644
--- a/tools/@o3r/build-helpers/scripts/pr-labels.mjs
+++ b/tools/@o3r/build-helpers/scripts/pr-labels.mjs
@@ -1,6 +1,7 @@
 import { EOL } from 'node:os';
 import { spawnSync } from 'node:child_process';
-import { promises as fs, existsSync } from 'node:fs';
+import { promises as fs, existsSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
 import { join, resolve } from 'node:path';
 import minimist from 'minimist'
 
@@ -37,9 +38,9 @@ const messageTagMaps = {
  * Get labels from the git log output command
  *
  * @param {string} targetBranch
- * @return {Promise<string[]>}
+ * @return {string[]}
  */
-async function getLabelsFromMessage(targetBranch, config) {
+function getLabelsFromMessage(targetBranch, config) {
   if (!config.enableCommitMessageLabel) {
     return [];
   }
@@ -71,28 +72,25 @@ async function getLabelsFromProjects(targetBranch, config) {
   const /** @type {string[]} */ listTouchedFiles = spawnSync('git', ['log', `${targetBranch}..HEAD`, '--name-only', '--pretty=format:""'], { encoding: 'utf-8', shell: true }).stdout.trim()
     .split(EOL)
     .map((file) => file.replace(/\\/g, '/')) || [];
-  const commitMessages = spawnSync('yarn', ['nx', 'show', 'projects', '--affected', `--base=${targetBranch}`], { encoding: 'utf-8', shell: true }).stdout.trim() || '';
-  const lines = commitMessages?.split(EOL).filter((line) => !!line) || [];
+
+  const tempDirPath = join(tmpdir(), 'pr-labels');
+  const graphJsonPath = join(tempDirPath, 'graph.json')
+  spawnSync('yarn', ['nx', 'graph', '--file', graphJsonPath], { encoding: 'utf-8', shell: true });
+  const { graph } = JSON.parse(await fs.readFile(graphJsonPath, { encoding: 'utf-8' }));
+  rmSync(tempDirPath, { recursive: true });
+  const projects = Object.entries(graph.nodes);
   const labels = [];
-  // console.log(lines);
-
-  for(const projectName of lines) {
-    const projectString = spawnSync('yarn', ['nx', 'show', 'project', projectName, '--json'], { encoding: 'utf-8', shell: true }).stdout.trim();
-    try {
-      const project = JSON.parse(projectString);
-      if (listTouchedFiles.some((file) => file.startsWith(project.root))) {
-        const packageJson = join(project.root, 'package.json');
-        const /** @type {string | undefined} */ packageName = JSON.parse(await fs.readFile(packageJson, { encoding: 'utf-8' })).name;
-        if (!packageName) {
-          process.stderr.write(`No package name found for ${projectName}${EOL}`);
-          continue;
-        }
-        if (!config.ignoredProjects.includes(packageName)) {
-          labels.push(`${config.projectLabelPrefix}${packageName}`);
-        }
+  for(const [projectName, { data: project }] of projects) {
+    if (listTouchedFiles.some((file) => file.startsWith(project.root))) {
+      const packageJson = join(project.root, 'package.json');
+      const /** @type {string | undefined} */ packageName = JSON.parse(await fs.readFile(packageJson, { encoding: 'utf-8' })).name;
+      if (!packageName) {
+        process.stderr.write(`No package name found for ${projectName}${EOL}`);
+        continue;
+      }
+      if (!config.ignoredProjects.includes(packageName)) {
+        labels.push(`${config.projectLabelPrefix}${packageName}`);
       }
-    } catch(e) {
-      process.stderr.write(`Failed to analyze ${projectName}${EOL}`);
     }
   }
 
@@ -127,7 +125,7 @@ void(async () => {
 
   const config = await getConfig();
   const target = `remotes/origin/${args.target}`;
-  const labelFromMessage = await getLabelsFromMessage(target, config);
+  const labelFromMessage = getLabelsFromMessage(target, config);
   const labelFromProject =  !config.ignoreProjectForLabels.some((label) => labelFromMessage.includes(label)) ?
     await getLabelsFromProjects(target, config) :
     [];