Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included Themes #19

Closed
petrockblog opened this issue Sep 19, 2012 · 3 comments
Closed

Included Themes #19

petrockblog opened this issue Sep 19, 2012 · 3 comments

Comments

@petrockblog
Copy link

With the theme engine working, I think it would make sense to include at least one or even more themes that the users could choose from. What do you think?

@Aloshi
Copy link
Owner

Aloshi commented Sep 19, 2012

You can place a 'default' theme in ~/.emulationstation/theme.xml if I remember correctly. If you can find/make a nice theme, just have RetroPie-Setup copy it there. I'm not sure if I want to add a default theme to the git project, since there's no guarantee that the user is running from the "correct" working directory for ES to load a theme from.

Adding system-specific themes to RetroPie-Setup is possible, but it would clutter the ROM directory as it stands now. At some point I'm going to make the load path for themes defined by a variable in es_systems.cfg, so that the theme files can stay away from the ROM files - then you could keep themes in one folder with a structure like:

--esthemes/
-----nestheme.xml
-----snestheme.xml
-----nes_art/
----------background.jpg
----------header.jpg
-----snes_art/
----------background.jpg

I'll try adding this change later tonight.

@petrockblog
Copy link
Author

Ok then, I was just wondering in which repository you would like to have the themes. I will add this to the issues list in the RetroPie repository! I hope that I will finally find some time to work on the script again next weekend.

Your idea about the load path variable is great and would definitely help to have a clear separation between configurations and roms! Thanks also for your initial thoughts on the folder structure.

@petrockblog
Copy link
Author

I just commited an update for the RetroPie script that also includes the themes for NES and SNES by @xevin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants