Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise notification importance #167

Closed
dJani97 opened this issue Sep 10, 2022 · 1 comment
Closed

Raise notification importance #167

dJani97 opened this issue Sep 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dJani97
Copy link

dJani97 commented Sep 10, 2022

I'm considering to use this package in an app, so I was reading thought the issues.

Problem

I found two issues concerning notification importance

The subject of these issues is the fact that notification importance is currently set to low, which is not desirable as the system may not show, or hide the notification after a while:

val mChannel = NotificationChannel(CHANNEL_ID, name, NotificationManager.IMPORTANCE_LOW)

Solution

In issue #96 the author mentions a fork of this repository in which he implemented a fix. It can be seen in this commit:

The changes can be seen here:

https://github.com/willhaslett/background_location_important/commit/45797a7082c84910544cb0b99e239e3566cfee31

It's basically changing NotificationManager.IMPORTANCE_LOW to NotificationManager.IMPORTANCE_DEFAULT.

Can you please also implement it this in this repository?

@dJani97 dJani97 changed the title Raise notification importance to IMPORTANCE_DEFAULT Raise notification importance Sep 10, 2022
@MoralCode MoralCode added the enhancement New feature or request label Jul 21, 2023
@Almoullim
Copy link
Owner

fixed in 52ef3db version 0.12.0

@Almoullim Almoullim self-assigned this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants