-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved filtering #249
Comments
@dana2208, it's a good features, feel free to contribute and discuss with me :) |
Hello @AllenFang, I implemented for the moment 2 types of filters:
The filters are rendered in the render method of TableColumnHeader. Since this React component is not a child of the BootstrapTable I couldn't use the regular React way to communicate between the 2 components. Please look at the code and let me know if you agree with the current implementation. |
@dana2208, thanks this improvement, because chinese new year was coming, I'm going to take vacation in these day. Anyway, if this patch is all work fine, just make a PR, I'll review it. btw, I've ran up your examples, It's look like perfect :), but some questions as following:
Thanks a lots 👍 |
Hi,
Would you be interested in a pull request where filters are part of the table header and could be either:
I am actually developing that by hooking the react-bootstrap-table, but I think it would be great if it would be part of it.
What do you think?
The text was updated successfully, but these errors were encountered: