Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control over the filter #6

Open
AllenEllis opened this issue Jan 4, 2020 · 0 comments
Open

More control over the filter #6

AllenEllis opened this issue Jan 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@AllenEllis
Copy link
Owner

From my Twitter DM

Allow for different filters including no filter over the images used.

The filters are actually critical to the legibility of the text. The colors I selected also tie into the campaigns brand styleguide and create consistency between the generated images, so I'm pretty hesitant to allow users to meddle. I'm also concerned that too many options and sliders on the generator will just lead to fewer people generating images (the paradox of choice).

My hunch is that the real reason people don't always like the image is because some source images are too dark or too bright, which result in a mostly blue or mostly yellow result. I think the correct fix here is to create either two sliders for brightness & contrast, or a single slider to control the gamma curve. I'm pretty confident this one slider will let people dial in the image to be the correct balance and fix this issue overall.

Requirements:

  • On the preview interface, a new slider that controls the gamma of the background image
  • New variables allowing that data to be passed along to the HTML generator
@AllenEllis AllenEllis added the enhancement New feature or request label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant