Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quest book spelling and grammar #1983

Closed
wants to merge 3 commits into from

Conversation

cla311
Copy link

@cla311 cla311 commented Jan 26, 2025

  • Reimplement grammar and spelling fixes in Apothic Enchanting quests from small quest fixes #1651 that at some point got overwritten and add new fixes
  • Fix Allthemodium (official capitalization) incorrectly being capitalized as AllTheModium in quest descriptions
  • Fix Forbidden and Arcanus (official mod name) being incorrectly referenced in the quest book with "&" instead of "and" or as Forbidden Arcanus

@TheBedrockMaster
Copy link
Member

Do you mind if I close this PR and remake it with some of your tweaks later? I'll make sure you get credited the same.

@cla311
Copy link
Author

cla311 commented Jan 26, 2025

@TheBedrockMaster Go ahead. Just make sure it doesn’t get overwritten by another pr again down the line like the one I mentioned above did.

@TheBedrockMaster
Copy link
Member

I’ll make sure off it :) Do you know which PR overwrote it?

@pr0saic
Copy link
Contributor

pr0saic commented Jan 26, 2025

It was #1674

@cla311
Copy link
Author

cla311 commented Jan 26, 2025

@TheBedrockMaster Btw, the same guy who made #1674 is also making the Immersive Engineering Quests pr #1967, which also includes the commits from #1674. Just make sure that that pr doesn’t overwrite these changes here, or we’ll have to make them again.

@cla311 cla311 deleted the quest-spelling-grammar branch January 26, 2025 23:01
@TheBedrockMaster
Copy link
Member

It was #1674

Every time.

@TheBedrockMaster
Copy link
Member

@TheBedrockMaster Btw, the same guy who made #1674 is also making the Immersive Engineering Quests pr #1967, which also includes the commits from #1674. Just make sure that that pr doesn’t overwrite these changes here, or we’ll have to make them again.

Yeah, he’s the main quest dev, if it does overwrite anything I’ll replace it :)

@cla311 cla311 restored the quest-spelling-grammar branch January 28, 2025 02:24
@cla311
Copy link
Author

cla311 commented Jan 28, 2025

Just wanted to note that the "Emerald Generator" quest has mistakenly been renamed as "Emerald Furnace", making it the same name as the actually "Emerald Furnace" quest even though both quests are totally different.

@cla311
Copy link
Author

cla311 commented Jan 28, 2025

I have updated my fork so my fixes are applied to the current main branch version. The issues I mentioned above along with some misc. spelling mistakes were added Apothic Enchanting quests fix commit as to not lose them when fixing the merge conflict.

@TheBedrockMaster
Copy link
Member

Most of this has kind of just resolved itself since, but thank you, will have a little look again when I get a chance just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants