-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sandbox Python runtime completely transparent #2796
Make the sandbox Python runtime completely transparent #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Shimada666 error in CI here:
I'll let this rerun and see if it still comes back this way. |
Repeated run shows the same error, just fyi. |
@tobitege |
@xingyaoww @tobitege |
It's rolling now 😂 |
everything looks good, is it ready to merge? |
@iFurySt Yes. please merge this PR, thanks! |
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Right now,
python
points to/opendevin/miniforge3/bin/python
, which is not suitable. Users should use a clean Python interpreter that is separate from the python used by the opendevin runtime.Give a brief summary of what the PR does, explaining any non-trivial design decisions
We should make the OpenDevIn Python runtime completely transparent to users. Users should continue using whatever interpreter
python
points to, like/usr/bin/python
, instead of/opendevin/miniforge3/bin/python
.Other references