Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary stuff from the sandboxes tests #2095

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented May 27, 2024

Remove extra "resets" from the sandboxes tests:

  • it should not be necessary, fixtures or tests should set their stuff and clean that up at the end
  • it causes issues, when env vars are unexpectedly not respected, like in Persistent docker session #1998

@SmartManoj SmartManoj merged commit 55fdee3 into main May 27, 2024
2 checks passed
@SmartManoj SmartManoj deleted the enyst/fix_fixture branch May 27, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants