Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Double scroll on file editor component hides save button #5391

Closed
1 task done
malhotra5 opened this issue Dec 3, 2024 · 4 comments
Closed
1 task done

[Bug]: Double scroll on file editor component hides save button #5391

malhotra5 opened this issue Dec 3, 2024 · 4 comments
Assignees
Labels
bug Something isn't working frontend Related to frontend good first issue Good for newcomers

Comments

@malhotra5
Copy link
Contributor

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

Theres a double scroll on the file editor component.

  1. You can scroll the code file
  2. You can also scroll the code file's container, which ends up hiding the "save" button

Once you scroll the container down, you can't scroll back up 🙂

OpenHands Installation

app.all-hands.dev

OpenHands Version

latest

Operating System

MacOS

Logs, Errors, Screenshots, and Additional Context

Scroll.bug.mov
@malhotra5 malhotra5 added bug Something isn't working good first issue Good for newcomers frontend Related to frontend labels Dec 3, 2024
@dannypaz
Copy link

dannypaz commented Dec 3, 2024

@malhotra5 Q for you. What is the expected functionality? Should we remove the ability to scroll on the files container OR do we want to handle scrolling updown on that window?

@malhotra5
Copy link
Contributor Author

Hi @dannypaz! I'm not sure if I understand the question, but let me rephrase the requirements. We want to be able to independently scroll

  • The workspace file directory
  • The code file

We don't want to scroll

  • The parent component of the code file (because it hides the save/discard buttons from view and can't be recovered as shown in the video). Another way of saying this is the save/discard buttons should be a sticky component that don't leave the view even when the file directory or code files are being scrolled

@dannypaz
Copy link

dannypaz commented Dec 4, 2024

@malhotra5 thank you. that is what I was wondering. I will take a stab at it

@malhotra5
Copy link
Contributor Author

Closing as resolved by #5488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants