Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making container final #24

Closed
ilyapuchka opened this issue Dec 6, 2015 · 2 comments
Closed

Making container final #24

ilyapuchka opened this issue Dec 6, 2015 · 2 comments
Milestone
4.0.0

Comments

@ilyapuchka
Copy link
Collaborator

Should we make DependencyContainer class final? I don't think there are any use cases for subclassing it. If clients want to extend behavior of container they can use composition. Also we never thought about supporting inheritance (maybe some properties should be not internal/private for that) so it can be just safer for clients to make it final.
@ilyapuchka ilyapuchka added this to the 4.0.0 milestone Dec 6, 2015
@AliSoftware
Copy link
Owner

👌

http://youtu.be/ZXsQAXx_ao0

@ilyapuchka
Copy link
Collaborator Author

Resolved by 6ad4b82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@AliSoftware @ilyapuchka