fix(storage-client): nodejs memory leak issue

Alwatr · Nov 19, 2022 · d5e0cde · d5e0cde
1 parent 859cc21
commit d5e0cde
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/core/storage-client/src/storage-client.ts b/packages/core/storage-client/src/storage-client.ts
@@ -70,7 +70,9 @@ export class AlwatrStorageClient<DocumentType extends DocumentObject> {
    */
   fetchOption: Partial<FetchOptions> = {
     keepalive: true,
-    timeout: this.config.timeout ?? 3_000,
+    timeout: this.config.timeout ?? 0,
+    cacheStrategy: 'network_only',
+    removeDuplicate: 'never',
     retry: 3,
     retryDelay: 300,
     headers: {
@@ -185,11 +187,7 @@ export class AlwatrStorageClient<DocumentType extends DocumentObject> {
       queryParameters: {
         storage: this.config.name,
       },
-      headers: {
-        ...this.fetchOption.headers,
-        'Content-Type': 'application/json',
-      },
-      body: JSON.stringify(documentObject),
+      bodyJson: documentObject,
     });
 
     let content: ServerResponse<DocumentType>;

diff --git a/packages/core/storage-client/src/type.ts b/packages/core/storage-client/src/type.ts
@@ -19,7 +19,9 @@ export type AlwatrStorageClientConfig = {
   /**
    * A timeout in ms for the fetch request.
    *
-   * @default 10_000 ms
+   * Use with cation, you will have memory leak issue in nodejs.
+   *
+   * @default 0 disabled
    */
   timeout?: number;