fix(crawler): handle null max price

Alwatr · Dec 6, 2022 · b34689e · b34689e
1 parent 31e9688
commit b34689e
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/crawler/src/crawl.ts b/crawler/src/crawl.ts
@@ -11,21 +11,21 @@ export async function crawlAllJobs(): Promise<void> {
   const jobList = await storage.getAll();
   for (const jobId in jobList) {
     if (!Object.prototype.hasOwnProperty.call(jobList, jobId)) continue;
-    const job = jobList[jobId];
-    const oldResultList = job.resultList;
-    const resultList = await crawl(job.detail);
-    job.resultList = resultList;
-    if (differentObject(resultList, oldResultList)) {
-      const message = makeMessage(job);
-      try {
+    try {
+      const job = jobList[jobId];
+      const oldResultList = job.resultList;
+      const resultList = await crawl(job.detail);
+      job.resultList = resultList;
+      if (differentObject(resultList, oldResultList)) {
+        const message = makeMessage(job);
         await notify(config.notifier.to, message);
         logger.logOther(`Notified to ${config.notifier.to}!`);
       }
-      catch (err) {
-        logger.error('crawlAllJobs', 'notify_failed', (err as Error).stack || err);
-      }
+      await storage.set(job);
+    }
+    catch (err) {
+      logger.error('crawlAllJobs', 's', (err as Error).stack);
     }
-    await storage.set(job);
   }
 }
 
@@ -97,8 +97,9 @@ function extraFilterResult(jobResultList: Array<JobResult>, detail: JobDetail):
   let filteredJobResultList: Array<JobResult> = jobResultList;
 
   if (detail.maxPrice != null) {
+    const maxPrice = detail.maxPrice;
     filteredJobResultList = filteredJobResultList.filter((job) => {
-      return job.price >= detail.maxPrice;
+      return job.price >= maxPrice;
     });
   }