fix(ns/storage): review and fix issues

Alwatr · Nov 15, 2022 · 658426a · 658426a
1 parent 97397f9
commit 658426a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/nanoservice/storage/src/route/get.ts b/packages/nanoservice/storage/src/route/get.ts
@@ -6,13 +6,13 @@ import type {AlwatrConnection} from '@alwatr/nano-server';
 
 nanoServer.route('GET', '/', getDocument);
 
-async function getDocument(connection: AlwatrConnection): Promise<void> {
+function getDocument(connection: AlwatrConnection): void {
   logger.logMethod('getDocument');
 
   const token = connection.requireToken(config.token);
   if (token == null) return;
 
-  const params = connection.requireQueryParams<{storage: string, id: string}>({'storage': 'string', 'id': 'string'});
+  const params = connection.requireQueryParams<{storage: string, id: string}>({storage: 'string', id: 'string'});
   if (params == null) return;
 
   const storage = storageProvider.get({name: params.storage});

diff --git a/packages/nanoservice/storage/src/route/remove.ts b/packages/nanoservice/storage/src/route/remove.ts
@@ -12,7 +12,7 @@ async function removeDocument(connection: AlwatrConnection): Promise<void> {
   const token = connection.requireToken(config.token);
   if (token == null) return;
 
-  const param = connection.requireQueryParams<{storage: string, id: string}>({'storage': 'string', 'id': 'string'});
+  const param = connection.requireQueryParams<{storage: string, id: string}>({storage: 'string', id: 'string'});
   if (param === null) return;
 
   const storage = storageProvider.get({name: param.storage});

diff --git a/packages/nanoservice/storage/src/route/update.ts b/packages/nanoservice/storage/src/route/update.ts
@@ -13,13 +13,13 @@ async function updateDocument(connection: AlwatrConnection): Promise<void> {
   const token = connection.requireToken(config.token);
   if (token == null) return;
 
-  const param = connection.requireQueryParams<{storage: string}>({'storage': 'string'});
+  const param = connection.requireQueryParams<{storage: string}>({storage: 'string'});
   if (param === null) return;
 
   const document = await connection.requireJsonBody<DocumentObject>();
   if (document == null) return;
 
-  if (document._id.length === 0) {
+  if (!(typeof document._id === 'string' && document._id.length !== 0)) {
     return connection.reply({
       ok: false,
       statusCode: 406,