Skip to content

Commit

Permalink
fix(signal): disabled getter and optional dispatch options
Browse files Browse the repository at this point in the history
  • Loading branch information
AliMD committed Mar 11, 2022
1 parent cbd9c69 commit 28ced3d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package/signal/src/signal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class SignalInterface<SignalName extends keyof VatrSignals> {
/**
* Disable signal, all dispatch's ignored (just value updated) and no more listeners will be called.
*/
get disable(): boolean {
get disabled(): boolean {
return this._signal.disabled;
}
set disabled(disabled: boolean) {
Expand Down Expand Up @@ -198,7 +198,7 @@ export class SignalInterface<SignalName extends keyof VatrSignals> {
* contentChangeSignal.dispatch(content);
* ```
*/
dispatch(signalValue: VatrSignals[SignalName], options: DispatchOptions): void {
dispatch(signalValue: VatrSignals[SignalName], options?: DispatchOptions): void {
this._logger.logMethodArgs('dispatch', {signalValue, options});
_dispatchSignal(this._signal.name, signalValue, options);
}
Expand Down

0 comments on commit 28ced3d

Please sign in to comment.