Skip to content

Commit

Permalink
fix: incorrect angular attributes in search components (#9479)
Browse files Browse the repository at this point in the history
  • Loading branch information
DenysVuika authored Mar 27, 2024
1 parent 97a2d98 commit 3dff1e0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 16 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-tabbed-' + tabbedFacet.label"
disableRipple
[disableRipple]="true"
class="adf-search-filter-chip-tabbed"
[class.adf-search-toggle-chip]="displayValue || menuTrigger.menuOpen"
[disabled]="!isPopulated"
tabIndex="0"
[tabIndex]="0"
[matMenuTriggerFor]="menu"
(onMenuOpen)="onMenuOpen()"
(menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()"
(keydown.escape)="onEscKeydown()"
[attr.title]="displayValue"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-' + field.label"
disableRipple
[disableRipple]="true"
class="adf-search-filter-chip adf-search-filter-facet-chip"
[class.adf-search-toggle-chip]="(facetField.displayValue$ | async) || menuTrigger.menuOpen"
[disabled]="!isPopulated()"
tabIndex="0"
[tabIndex]="0"
[matMenuTriggerFor]="menu"
(menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-' + category.name"
disableRipple
[disableRipple]="true"
class="adf-search-filter-chip"
[class.adf-search-toggle-chip]="(widget.getDisplayValue() | async) || menuTrigger.menuOpen"
tabIndex="0"
[tabIndex]="0"
[matMenuTriggerFor]="menu"
(menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,25 @@

<ng-container *ngIf="forms.length === 1">
<button class="adf-search-form adf-search-form-button"
[disableRipple] mat-button
[disableRipple]="true"
mat-button
[title]="getSelected(forms) | translate"
[attr.aria-label]="getSelected(forms) | translate">
<span class="adf-search-form-title">
{{ getSelected(forms) | translate }}
</span>
<span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
</button>
</ng-container>

<ng-container *ngIf="forms.length > 1">
<button class="adf-search-form adf-search-form-button"
[matMenuTriggerFor]="menu"
#menuTrigger="matMenuTrigger"
[disableRipple]
[disableRipple]="true"
mat-button
[title]="getSelected(forms) | translate"
[attr.aria-label]="getSelected(forms) | translate"
[matMenuTriggerRestoreFocus]="true">

<span class="adf-search-form-title" >
{{ getSelected(forms) | translate }}
</span>

<span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
<mat-icon [class.adf-search-form-icon-selected]="menuTrigger.menuOpen" class="adf-search-form-icon">expand_more</mat-icon>
</button>

Expand Down

0 comments on commit 3dff1e0

Please sign in to comment.