Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to F-froid #3

Open
inson1 opened this issue Feb 26, 2024 · 5 comments
Open

Add to F-froid #3

inson1 opened this issue Feb 26, 2024 · 5 comments

Comments

@inson1
Copy link
Contributor

inson1 commented Feb 26, 2024

Did you think about adding it to F-droid too? Its more restrictive, but that is good thing

With reproducible builds ofc

@IzzySoft
Copy link

IzzySoft commented Mar 2, 2024

With today's update of the app, this will no longer be an option – as a non-free component was added: Google Mobile Services. Which is not permitted at F-Droid. And raises a red flag in my repo, where the app is currently listed.

So @Alfio010, two questions: why did you add this dependency (what is it needed for) – and would you consider removing it again or at least provide a build flavor without it?

Ah, found the culprit. Don't be fooled by that module being called oss-licenses. Tue, it lists open-source licenses, but it's not truly FOSS itself as it drags in non-free stuff as you see here. Easy to be solved by using one of the available alternatives. With your app using GPL-3.0, AboutOss would be a good match as it uses the same. But take your pick. Until then, I'll have to raise the NonFreeComp anti-feature here.

@Alfio010
Copy link
Owner

Alfio010 commented Mar 2, 2024

With today's update of the app, this will no longer be an option – as a non-free component was added: Google Mobile Services. Which is not permitted at F-Droid. And raises a red flag in my repo, where the app is currently listed.

So @Alfio010, two questions: why did you add this dependency (what is it needed for) – and would you consider removing it again or at least provide a build flavor without it?

Ah, found the culprit. Don't be fooled by that module being called oss-licenses. Tue, it lists open-source licenses, but it's not truly FOSS itself as it drags in non-free stuff as you see here. Easy to be solved by using one of the available alternatives. With your app using GPL-3.0, AboutOss would be a good match as it uses the same. But take your pick. Until then, I'll have to raise the NonFreeComp anti-feature here.

Thanks for letting me know, I hadn't thought about this, as soon as I can I will replace the library in question with one of those you suggested.

@IzzySoft
Copy link

IzzySoft commented Mar 3, 2024

Thanks! Once that's in place with a new release, please let me know so I can remove the anti-feature again.

@Alfio010
Copy link
Owner

Thanks! Once that's in place with a new release, please let me know so I can remove the anti-feature again.

I finally did it with version 2.2

@IzzySoft
Copy link

Ah, right, my updater already informed me and I appraised it yesterday 😉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants