-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: maybe not use latest
as the defaultBranch
?
#132
Comments
Tagging @allyhawkins & @jaclyn-taroni for comment. |
I'm tempted to go with this option. It seems the most straight forward for users and also would work well for us. The other options are not impossible to get around, but seem more error prone for users. |
Agreed. |
Okay! Sounds good to me. I will work on setting that up, including some updated instructions. |
Just hopping in to say thank you for documenting this; I am running into this issue and this thread was very helpful! |
In trying to test the latest updates, I ran into an interesting little situation where Nextflow was not behaving quite as I expected it to.
I wanted to test the first run experience for users, so I ran
nextflow drop alexslemonade/scpca-nf
to clear the downloaded workflow cache.Next I tried to run
nextflow run alexslemonade/scpca-nf
, which resulted in the following error:The cause of this error seems to be that nextflow only pulls the GitHub default branch, so the
latest
branch was not present, and thus it could not find it to run.Using
nextflow run alexslemonade/scpca-nf -r latest
does work, and subsequent runs work as expected, with no need to specify the revision.So I thought there might be a couple options:
-r latest
flag, but a hope was that we could eliminate that flag for easier running.nextflow pull alexslemonade/scpca-nf -r latest
as a first step, which should then allow them to use barenextflow run alexslemonade/scpca-nf
when running the workflow.manifest.defaultBranch
tomain
, which should allow for the barenextflow run alexslemonade/scpca-nf
to work without a mysterious error. In this case, I think we would want to create a separatedev
branch to use as we add features, merging usually to that branch and then fromdev
intomain
when we are preparing a release.(My ideal solution would probably be for Nextflow to automatically pull whatever is specified in the
manifest.defaultBranch
, but judging by the age of this issue, I am not optimistic for a quick fix on that front. I think the expectation is thatmanifest.defaultBranch
is matching the GitHub default branch. )The text was updated successfully, but these errors were encountered: