From 709e6d7d1ebc981d13a8013ea5a6733092c9b31f Mon Sep 17 00:00:00 2001 From: Alex Huszagh Date: Thu, 6 Feb 2025 10:38:37 -0600 Subject: [PATCH] Patch use of `set_precision` on i586. Closes #218. --- .github/workflows/Cross.yml | 2 ++ CHANGELOG | 1 + lexical-parse-float/src/number.rs | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Cross.yml b/.github/workflows/Cross.yml index 03cff06d..d22b0f46 100644 --- a/.github/workflows/Cross.yml +++ b/.github/workflows/Cross.yml @@ -24,6 +24,8 @@ jobs: - aarch64-unknown-linux-gnu - arm-unknown-linux-gnueabi - armv7-unknown-linux-gnueabihf + # NOTE: Required for issue #218 + - i586-unknown-linux-gnu - i686-unknown-linux-gnu - i686-unknown-linux-musl # NOTE: This fails on cross v0.2.1, which is unusual since diff --git a/CHANGELOG b/CHANGELOG index 93f1ec98..7db49022 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Patch doctests with TODOs in dependencies (#222). - CI with OSS-Fuzz for the deprecated `actions/upload-artifact@v3` (#221). +- Float parsing on `i586` targets (#219). - Bug where the `radix` feature wasn't enabling `power-of-two` in `lexical-core` or `lexical` (#204). - Fixed performance issues due to a lack of inlining on the Eisel-Lemire algorithm (#210). - Issue with parsing non-decimal exponent radixes when using a decimal mantissa radix for floating-point numbers (#212). diff --git a/lexical-parse-float/src/number.rs b/lexical-parse-float/src/number.rs index 4e783e73..5d8c2102 100644 --- a/lexical-parse-float/src/number.rs +++ b/lexical-parse-float/src/number.rs @@ -74,7 +74,7 @@ impl Number<'_> { // function takes care of setting the precision on architectures which // require setting it by changing the global state (like the control word of the // x87 FPU). - let _cw: () = set_precision::(); + let _cw = set_precision::(); if self.is_fast_path::() { let radix = format.radix();