Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused workspace doesn't show workspace number #2295

Closed
Kagukara opened this issue Jul 8, 2023 · 11 comments
Closed

Focused workspace doesn't show workspace number #2295

Kagukara opened this issue Jul 8, 2023 · 11 comments
Labels
bug Something isn't working regression

Comments

@Kagukara
Copy link

Kagukara commented Jul 8, 2023

Version: Waybar v0.9.19
Last Updated: 2023-07-08 00:00 UTC (https://archlinux.org/packages/extra/x86_64/waybar/)

After updating waybar the focused workspace no longer has its number and now looks like this:
capture_2023-07-08_23-49-52

When before it was like this:
capture_2023-07-08_23-56-28

I have tried messing with the #workspaces button.focused part in my style.css but nothing has worked.

@ohdearaugustin
Copy link

I can confirm the issue.

Downgraded to 0.9.18 and the issues disappeared.

@Alexays Alexays added bug Something isn't working regression labels Jul 9, 2023
@dotfrag
Copy link

dotfrag commented Jul 9, 2023

I was about to post this. It seems to have been introduced by this change https://github.com/Alexays/Waybar/pull/2223/files:

-  std::vector<std::string> keys = {name, "urgent", "focused", "visible", "default"};
+  std::vector<std::string> keys = {"urgent", "focused", name, "visible", "default"};

Before this update, Urgent workspaces wouldn't show the urgent icon because name had higher priority. Now, urgent icon shows because it has the highest priority, but name doesn't show on focused workspace, because focused takes precedence. I believe the correct order would be:

std::vector<std::string> keys = {"urgent", name, "focused", "visible", "default"};

@julkefol
Copy link

julkefol commented Jul 9, 2023

I use nerdfont icons. In my case workspace icon replaced by "focused" icon.

After update: up.png

After downgrade: down.png

@dottorblaster
Copy link

Same, I can confirm the same behavior as @jcnafi

image

@Kagukara
Copy link
Author

v0.9.18 doesn't load anymore and says waybar: error while loading shared libraries: libfmt.so.9: cannot open shared object file: No such file or directory. Seems to be because fmt was updated.

Updating to Waybar v0.9.20 and also trying Waybar v0.9.20-48-g20b091dc (branch 'master'), this issue is still present. Will this be getting fixed anytime soon?

@tyrumus
Copy link

tyrumus commented Jul 29, 2023

@Kagukara #2223 technically solves this issue, but it requires you to update your config to restore the previous functionality that you were probably expecting. Simply add an array of the workspace names that you want to continue showing the name/icon despite being the focused workspace.

Here's an example. This currently only works on master.

@dotfrag
Copy link

dotfrag commented Jul 30, 2023

@tyrumus where did you find that configuration option? I can't seem to find it in the wiki nor it works for me. I still don't see the workspace icons.

EDIT: I just noticed you said master, so probably not released yet.

@Kagukara
Copy link
Author

@Kagukara #2223 technically solves this issue, but it requires you to update your config to restore the previous functionality that you were probably expecting. Simply add an array of the workspace names that you want to continue showing the name/icon despite being the focused workspace.

Here's an example. This currently only works on master.

That worked, thank you.

@a1akris
Copy link

a1akris commented Sep 5, 2023

Apparently, this issue was fixed by this patch #2336. I've just added an example to the Wiki that shows how to attain the old behavior.

@julkefol
Copy link

julkefol commented Sep 6, 2023

yeah, it get solved putting "high-priority-named": ["1", "2"] inside "format-icons":.

@dottorblaster
Copy link

dottorblaster commented Sep 6, 2023

Same. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

No branches or pull requests

8 participants