Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android cannot build with minSdkVersion in AndroidManifest #301

Open
olibooty opened this issue Feb 8, 2023 · 1 comment
Open

Android cannot build with minSdkVersion in AndroidManifest #301

olibooty opened this issue Feb 8, 2023 · 1 comment

Comments

@olibooty
Copy link

olibooty commented Feb 8, 2023

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-i18n@2.0.15 for the project I'm working on.

I had a lint error while running a production build saying that minSdkVersion should be removed from AndroidManifest.xml and placed in build.gradle. As it was already in build.gradle, all I had to do was remove this line.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml b/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
index 818651f..3d228f4 100644
--- a/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.AlexanderZaytsev.RNI18n">
-    <uses-sdk android:minSdkVersion="16" />
 </manifest>

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@olibooty and others