Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: HW Accelerated HEVC decoding leading to inaccurate colors being displayed #70

Closed
ThaUnknown opened this issue Aug 22, 2022 · 12 comments

Comments

@ThaUnknown
Copy link

ThaUnknown commented Aug 22, 2022

System Details

Problem
HEVC Videos inaccurately calculate their color profiles leading to color inaccuracy, or simply making the video look more washed out than it actually is.

Screenshots
Left: actual
Right: expected
image
image

Devtools media tab:
image

Additional Notes
For comparison I used Muril's patch which doesn't enable hardware accelerated HEVC decoding for this very reason. This issue is effectively asking to stop using StaZhu's patch and instead switch to Muril's patch, which also includes EAC-3/AC-3

@Alex313031
Copy link
Owner

@ThaUnknown Thanks, I will look into it.

@Alex313031
Copy link
Owner

@ThaUnknown Updated ffmpeg patch and made minor adjustment. It should play HEVC with software decoding now, which is good for everyone, but it also might have resolved your color issue. Can you test latest release?

@ThaUnknown
Copy link
Author

using https://github.com/Alex313031/Thorium-Win/releases/tag/M109.0.5362.0
the issue doesn't seem fixed:
image
image

@gz83
Copy link
Collaborator

gz83 commented Oct 18, 2022

using https://github.com/Alex313031/Thorium-Win/releases/tag/M109.0.5362.0 the issue doesn't seem fixed: image image

@ThaUnknown Hi, can you send me the URL of your video? I'll test it here.

@ThaUnknown
Copy link
Author

@gz83 ah yes. url.

@gz83
Copy link
Collaborator

gz83 commented Oct 18, 2022

@gz83 ah yes. url.

@ThaUnknown sorry i didn't see the url you sent

@ThaUnknown
Copy link
Author

@gz83 ah yes. url.

@ThaUnknown sorry i didn't see the url you sent

yes, because it was a sarcastic stab at the fact that one didn't exist, but here, 24h to download then it expires:
https://wormhole.app/a4blj#mgEcOYPFL1OKUb-gb9Tu_g

@gz83
Copy link
Collaborator

gz83 commented Oct 18, 2022

@gz83 ah yes. url.

@ThaUnknown sorry i didn't see the url you sent

yes, because it was a sarcastic stab at the fact that one didn't exist, but here, 24h to download then it expires: https://wormhole.app/a4blj#mgEcOYPFL1OKUb-gb9Tu_g

image

This is my test result

@ThaUnknown
Copy link
Author

woah we have a 3rd result which also isnt correct
I'll make a gradient here:
image
order is windows/linux/target

@ThaUnknown
Copy link
Author

@Alex313031 seems this was fixed in StaZhu's patches, I don't know exactly when as I wasn't keeping a pulse on this.

@Alex313031
Copy link
Owner

@ThaUnknown Cool.

@Alex313031
Copy link
Owner

@gz83 close test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants