Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- #66

Closed
danielstreba opened this issue Aug 13, 2022 · 10 comments
Closed

- #66

danielstreba opened this issue Aug 13, 2022 · 10 comments

Comments

@danielstreba
Copy link

danielstreba commented Aug 13, 2022

@gz83
Copy link
Collaborator

gz83 commented Aug 13, 2022

Hi,

How can I disable these colored icons on the toolbars? I like the regular grey icon colors better. I'm using Thorium_AVX2_106.0.5199.0 at the moment.

Thanks.

image

@Alex313031 @danielstreba These icons have been changed at the code level, and how to deal with this issue needs to be decided by Alex

@Alex313031
Copy link
Owner

@danielstreba @gz83 I know they can be changed, as you can see in the TOOLBAR_TINT property when making a chrome theme, which changes the clours. I would like to add a flag which changes the colours of the .icon files, instead of hard coding them in the .icon files themselves. I understand that not everyone will want the new colours, I will work to make it an option rather than hard coded.

@Alex313031
Copy link
Owner

@danielstreba Still having trouble making this something not hard coded. Although I have reverted the reload button icon and cookies icon to blue, because using the greenish color of the chrome labs icon makes it too hard to see in light mode.

@Alex313031
Copy link
Owner

@danielstreba @gz83 Checking back in. Gz83, this is something still on the roadmap. Now that we have worked out pretty much all bugs and issues except all the win avx2 issues, I will be focusing more of my attention on developing a chrome://flags flag to toggle top bar icons. Its just a matter of finding where in source code this applies. It is not WebUI, but rather native chrome views. I feel that maybe thorium_ui_debug_shell could help with this. There is somewhere in code that sets the TINT variable, and this could be used to set the colours in the .icon files, without hard coding them in RGB like I showed you before.

@im-tem
Copy link

im-tem commented Apr 15, 2023

image
bump, this just doesn't work well with themes AT ALL

@l3ony2k
Copy link

l3ony2k commented Oct 17, 2023

Hi @Alex313031 been using Thorium for a while and having the same issue here, doesn't look good on any colored theme. Hope this can be fixed! So close to be perfect :)

@gz83
Copy link
Collaborator

gz83 commented Oct 18, 2023

The color of the icon changed because we hardcoded the color in the code, and we may change the icon subsequently

@Alex313031

@joaocastilho
Copy link

@Alex313031 maybe potentially revert them back to the default white while you still work on making it not hard coded?

@neo773
Copy link

neo773 commented Nov 4, 2023

Was looking to replace ungoogled chromium with Thorium but this is a blocker for me, also the contrast ratio is poor which affects accessibility

image

@danielstreba danielstreba changed the title How to disable colored toolbar icons? - Dec 21, 2023
@Alex313031 Alex313031 reopened this Feb 20, 2024
@Alex313031
Copy link
Owner

@joaocastilho @danielstreba @im-tem @neo773 Added in all releases now that M121 is released today. Closing issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants