-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- #66
Comments
@Alex313031 @danielstreba These icons have been changed at the code level, and how to deal with this issue needs to be decided by Alex |
@danielstreba @gz83 I know they can be changed, as you can see in the TOOLBAR_TINT property when making a chrome theme, which changes the clours. I would like to add a flag which changes the colours of the .icon files, instead of hard coding them in the .icon files themselves. I understand that not everyone will want the new colours, I will work to make it an option rather than hard coded. |
@danielstreba Still having trouble making this something not hard coded. Although I have reverted the reload button icon and cookies icon to blue, because using the greenish color of the chrome labs icon makes it too hard to see in light mode. |
@danielstreba @gz83 Checking back in. Gz83, this is something still on the roadmap. Now that we have worked out pretty much all bugs and issues except all the win avx2 issues, I will be focusing more of my attention on developing a chrome://flags flag to toggle top bar icons. Its just a matter of finding where in source code this applies. It is not WebUI, but rather native chrome views. I feel that maybe thorium_ui_debug_shell could help with this. There is somewhere in code that sets the TINT variable, and this could be used to set the colours in the .icon files, without hard coding them in RGB like I showed you before. |
Hi @Alex313031 been using Thorium for a while and having the same issue here, doesn't look good on any colored theme. Hope this can be fixed! So close to be perfect :) |
The color of the icon changed because we hardcoded the color in the code, and we may change the icon subsequently |
@Alex313031 maybe potentially revert them back to the default white while you still work on making it not hard coded? |
@joaocastilho @danielstreba @im-tem @neo773 Added in all releases now that M121 is released today. Closing issue now. |
The text was updated successfully, but these errors were encountered: