Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 3.2.0 crashes in windows 7 #17

Closed
pejman1 opened this issue Feb 14, 2022 · 5 comments
Closed

version 3.2.0 crashes in windows 7 #17

pejman1 opened this issue Feb 14, 2022 · 5 comments

Comments

@pejman1
Copy link

pejman1 commented Feb 14, 2022

I am writing to inform you there is bug in version 3.2.0 that cause app crashes in windows 7

@Alex-D
Copy link
Owner

Alex-D commented Mar 6, 2022

The real question is: should we support Windows 7 as of 2022?
Microsoft themself has ended support for Windows 7 already two years ago:
https://support.microsoft.com/en-us/windows/windows-7-support-ended-on-january-14-2020-b75d4580-2cc7-895a-2c9c-1466d9a53962

Also, without logs, I can't know the crash origin, so I can't fix it.

@pejman1
Copy link
Author

pejman1 commented Mar 6, 2022

The real question is: should we support Windows 7 as of 2022? Microsoft themself has ended support for Windows 7 already two years ago: https://support.microsoft.com/en-us/windows/windows-7-support-ended-on-january-14-2020-b75d4580-2cc7-895a-2c9c-1466d9a53962

Also, without logs, I can't know the crash origin, so I can't fix it.

there are many users that still use windows 7
there is no log and it hangs when we use this library . older versions have no problem

@Alex-D
Copy link
Owner

Alex-D commented Mar 6, 2022

The package code use this Powershell function here:

['powershell', 'Get-CimInstance -ClassName Win32_LogicalDisk | Select-Object Caption, FreeSpace, Size'],

that Microsoft documents as working since Windows Vista :/

I will download a Windows 7 VM to try to reproduce the crash

@Alex-D
Copy link
Owner

Alex-D commented Mar 7, 2022

I've installed a Windows 7 VM, and I can reproduce it since it seems to be due to PowerShell 2.

I've found some users complaining about that on the node repository:
nodejs/node#25645 (comment)

So, I need to find a workaround :/

@Alex-D
Copy link
Owner

Alex-D commented Mar 7, 2022

Fixed in 3.3.0

Now, I switch between the old and the new way depending on the Windows version used.
That way, I keep the support of older Windows that does not support PowerShell 3 which is needed for the Get-CimInstance cmdlet.

@Alex-D Alex-D closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants