Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.uncomment not removing "line" comments #1796

Closed
mathiasrw opened this issue Sep 15, 2023 · 3 comments
Closed

utils.uncomment not removing "line" comments #1796

mathiasrw opened this issue Sep 15, 2023 · 3 comments
Assignees
@vishal6557
Labels
Bug: Code provided to reproduced Good first issue Help wanted Related to: Code quality Was previously working

Comments

@mathiasrw
Copy link
Member

mathiasrw commented Sep 15, 2023 •
edited
Loading

alasql.utils.uncomment is meant to remove -- something comments, but is not.

Expected to work:

res = alasql.utils.uncomment('a -- wow\nb');
// res == 'a \nb'

Please update test 221 to show its working by removing the .skip in the first test.

Spawn from the work with #1795
@vishal6557
Copy link
Contributor

vishal6557 commented Sep 19, 2023 •
edited
Loading

Can I please work on this?

@mathiasrw
Copy link
Member Author

Yes, please.

I propose you also add a few more tests for the functionality so we know if we are breaking things while fixing.

@vishal6557 vishal6557 mentioned this issue Dec 2, 2023
Merged
@mathiasrw
Copy link
Member Author

Fix released as part of v4.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal6557 vishal6557

Labels
Bug: Code provided to reproduced Good first issue Help wanted Related to: Code quality Was previously working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathiasrw @vishal6557