Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local chain file option for MungeSumstats::liftover # enhancement #183

Closed
laleoarrow opened this issue Apr 23, 2024 · 1 comment
Closed

Comments

@laleoarrow
Copy link

laleoarrow commented Apr 23, 2024

Downloading chain files from the UCSC server is unnecessary and time-consuming, especially when dealing with a large amount of data requiring base position transformation. Allowing the option to load previously downloaded chain files would significantly enhance speed (as it only needs to be downloaded once) and reduce the load on the UCSC server.

@laleoarrow laleoarrow changed the title Add local chain file option for MungeSumstats::liftover Add local chain file option for MungeSumstats::liftover # enhancement Apr 23, 2024
@Al-Murphy
Copy link
Owner

Hey! Thanks for this and the PR - I will implement these changes with a few modifications so it is more generally useable.I'll also add some unit tests. Just to note though, get_chain_file() already has functionality to not download files more than once so it actually isn't that much of an issue but I agree having the option to use local versions is worthwhile.

Secondly, I'll propagate the parameter to format_sumstats() function as this will be the function most people use in the package. Going to close the PR and make these changes locally.

I'll add you as a contributor to the package README. Also worth you having a look at the changes I made (v 1.11.10), there was a a bit extra required from your PR to get it to work and worth being aware if you contribute again! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants