Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error when key field does not exist in item #265

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

lechinoix
Copy link
Contributor

Hello !

I just had a hard time understanding what was happening because I set badly the key-field prop on the DynamicScroller.

I propose this change so that the component fails faster with a clearer error, does this feel right to you ?

Thanks !

@rakermi
Copy link

rakermi commented Aug 5, 2019

For history, the issue is linked with this :
#96

@Akryum Akryum changed the base branch from master to v1 October 10, 2022 20:06
@Akryum Akryum changed the title Throw error when key field does not exist in item feat: throw error when key field does not exist in item Oct 10, 2022
@Akryum Akryum merged commit c63129f into Akryum:v1 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants