Added option to ignore URI parsing errors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a DataServiceContext there was a mandatory URI check relying on .NETs Uri.IsWellFormedUriString. Sadly there is an active issue on the .NET side that incorrectly flags URIs like "http://192.168.0.1:1234/Instance/ODataV4/Company('123-Customer Place Süd-Ost')/" as being invalid. The progress is tracked here: dotnet/runtime#21626 To give the user a simple option to prevent this issue from hindering further development with the library I added a simple bool to ignore this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a DataServiceContext there was a mandatory URI check
relying on .NETs Uri.IsWellFormedUriString. Sadly there is an active
issue on the .NET side that incorrectly flags URIs like
"http://192.168.0.1:1234/Instance/ODataV4/Company('123-Customer Place
Süd-Ost')/" as being invalid. The progress is tracked here:
dotnet/runtime#21626
To give the user a simple option to prevent this issue from hindering
further development with the library I added a simple bool to ignore
this error.