Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make person (album) editable #105

Open
puik opened this issue Jan 25, 2022 · 3 comments
Open

Make person (album) editable #105

puik opened this issue Jan 25, 2022 · 3 comments

Comments

@puik
Copy link
Member

puik commented Jan 25, 2022

We need have a view for editing person information that's available for all contributors. The view should also display person photo(s).

Data model:

  • firstname
  • lastname
  • other names
  • gender
  • birth date (different granularity – only year, exact date, approximate date)
  • death date
  • is public figure
  • labels
  • external IDs (ID label & value: wikidata ID & Q...; other external ids)

Shall we have another table for external IDs url-patterns?

Probably also needed is option of locking person editing.

Logging all the edits (something wiki-like?).

@puik puik added this to the Person tagging milestone Jan 25, 2022
@puik
Copy link
Member Author

puik commented Jan 25, 2022

NB! Names should not be machine translated but we need to have the option of capturing different forms of the name (royal persons, for instance) and in different alphabets (cyrillic is most important for us)

@MaertHaekkinen MaertHaekkinen changed the title persons editable Make person (album) editable Jan 31, 2022
@MaertHaekkinen
Copy link
Member

MaertHaekkinen commented Jan 31, 2022

I suggest that we reuse the album editor in curator.
There is something that needs fixing there anyway.

That is subalbum selection, which can time out. This is because it does not use autofill based on query. It fetches all 15k albums.

@MaertHaekkinen
Copy link
Member

The subalbum selection issue is now fixed. The component unfortunately isn't reusable yet. I avoided dropping any more hours into this one for now. As there are more pressing matters to work on for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants