Emit a metric when pghoard quits main loop #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiqin-Aiven
force-pushed
the
aiqin-quit-main-loop
branch
from
952b300
to
5da3474
Compare
|
will need to address rohmu PR first: Aiven-Open/rohmu#144 |
for example: for alerting purpose
Aiqin-Aiven
force-pushed
the
aiqin-quit-main-loop
branch
from
5da3474
to
dee324f
Compare
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 91.44% 91.35% -0.09%
==========================================
Files 32 32
Lines 4709 4710 +1
==========================================
- Hits 4306 4303 -3
- Misses 403 407 +4
|
alexole
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example: for alerting purpose
About this change - What it does
Emit a metric when there is unrecoverable error to quit main loop
So we can do some alert on services.
Why this way
A metric will generate each time if there is a main loop quit.