-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to Approve Topic Request #2490
Comments
Hi @luke-zhou apologies I didn't see this issue until now, Would you be able to check the logs and add them here? if you run the following command and then execute step 9 again gather those logs docker logs --follow klaw-core And repeat the same again for here: Apologies again for missing this post and not replying sooner. |
@luke-zhou I just followed the same steps on mac os, and it was ok. docker exec -it klaw-kafka /opt/bitnami/kafka/bin/kafka-topics.sh --list --bootstrap-server localhost:9092 |
Thank you for the logs, at the moment it looks like docker is not able to resolve the docker host to be able to call the cluster api and make the change. I do know the docker routing on Linux is different then on Mac and Windows and I also run ubuntu so I will try to reproduce and resolve this issue this morning. Thanks, and I'll get back to you soon! |
@luke-zhou Thanks a million again for raising this. The below changes the networking for linux.
For additional context, host.docker.internal was not supported on docker for linux, the networking changes for this were raised in this PR in 2019, it looks like it was closed in 2023, I am going to update the documentation to show a specific Linux setup to try it out. Also we have added a number of cool features to the Klaw UI since this demo was created so I am going to create an issue to update the current version we are using as well. |
Related Klaw-docs PR created |
I am afraid the issue is still existing. I have attached the log for core. |
Hey @luke-zhou did you delete the containers that already existed before copying and pasting the linux version of the docker command? As I can see in the logs it is still looking for host.docker.internal but that is not defined in the linux version anymore? |
what i did is |
That should be ok as long as the containers were stopped before you ran the command. can you run "docker container ls" and see how the ports are set up? if its properly taken the network = host the ports should all be blank |
Ok it looks like the deployment is working but if we are still seeing the old host.docker.internal in the api calls I think we need to update the setting as superadmin. You want to login as superadmin/welcometoklaw (or possibly kwsuperadmin123$$ for this deployment I'm not 100% sure) This will hopefully resolve the issue you were having. |
@aindriu-aiven , I tried to change the setting from host.docker.internal to localhost. After I changed, tested connection was ok, no issue. Then I retested the approve-topic issue, the issue was still existing. I thought I may need to restart the server. So I stopped the container, and tried to restart them, but container klaw-kafka failed to start |
Hey @luke-zhou thanks for following up on this can you send me the logs of the failed to start instance? This is very strange I have never seen anything like this before. |
@aindriu-aiven sorry, i am not familiar with docker, can you tell me how can I retrieve that log? |
Hey, no worries at all. If you could send the klaw-core and klaw-cluster-api logs again after the previous changes we made. docker logs --follow klaw-core |
Hey @luke-zhou good news is we now see that the core is able to communicate correctly with the API and it is now the api that is having trouble connecting to the kafka instance! If you sign in as superadmin again and go to clusters and edit cluster and change the bootstrap server to "localhost:9092" from the current "host.docker.internal:9092" I think we will finally see it working, you'll also be able to test that connectivity on the environment page. Because the instance was already setup the config was saved in the database meaning that this piece of config from the original deployment was kept. I think this should resolve the last bottleneck you have though to getting the flow end 2 end :) |
Yes, it is working now, thank you for your help @aindriu-aiven |
Super delighted that it got working! |
What happened?
Try to follow the Quickstart, when come to step 9 Approve request, fail to do that. The error on the page shows:
Failure unable to approve requestId 1002 Could not approve topic request. Please contact Administrator.
The text was updated successfully, but these errors were encountered: