Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma brightness control auto-deselects Gamma value = 1.0 #4469

Open
1 task done
adbern opened this issue Jan 9, 2025 · 4 comments
Open
1 task done

Gamma brightness control auto-deselects Gamma value = 1.0 #4469

adbern opened this issue Jan 9, 2025 · 4 comments
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details documentation documentation should be updated to explain behaviour

Comments

@adbern
Copy link

adbern commented Jan 9, 2025

What happened?

When gamma brightness control is selected and "saved" it auto unselects itself after "save" and also unselects gamma color correction.
Screenshot_20250108-215156

To Reproduce Bug

Select both gamma color and gamma brightness correction - change gamma value to 1.0, then save. Check if gamma correction is still checked.

Expected Behavior

Both gamma color and brightness should remain selected after save.

Install Method

Binary from WLED.me

What version of WLED?

WLED 0.15.0

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@adbern adbern added the bug label Jan 9, 2025
@DedeHai DedeHai added the cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details label Jan 9, 2025
@DedeHai
Copy link
Collaborator

DedeHai commented Jan 9, 2025

Tested on 0.15, saving works.
any more details on your setup and installation method? did you upgrade from an earlier verison or is it a fresh install?

@adbern
Copy link
Author

adbern commented Jan 11, 2025

Fresh install but I used the QuinLED DigOcta ethernet build: https://github.com/intermittech/QuinLED-Firmware/releases

It looks like if you set gamma to 1.0 it unchecks itself, but 1.1 doesn't? I'll try the non-Quin build and see if I can re-produce.

@adbern
Copy link
Author

adbern commented Jan 11, 2025

I also don't really notice a difference in performance when I change the gamma value...

@softhack007
Copy link
Collaborator

softhack007 commented Jan 12, 2025

Gamma = 1.0 basicially means "no gamma". Technically speaking, that's the same as disabling gamma correction, due to the underlying power-law formula.

Also gamma correction only applies to colors you select from the color picker, to custom palettes, and to global brightness (in case you set "use gamma correction for brightness").

The built-in colour palettes all have a fixed gamma of ~ 2.5 that can't be changed.

@softhack007 softhack007 added the documentation documentation should be updated to explain behaviour label Jan 12, 2025
@softhack007 softhack007 changed the title Gamma brightness control auto-deslects Gamma brightness control auto-deselects Gamma value = 1.0 Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details documentation documentation should be updated to explain behaviour
Projects
None yet
Development

No branches or pull requests

3 participants