Internal temperature causes 'error 12: preset not found' even without any presets

[orbitinstasis]

What happened?

every time i open one of my two wled instances, I get 'error 12: preset not found'

To Reproduce Bug

I have updated to version 15 recently and don't remember the error showing there, but I can isolate it to this mod because I emptied all my presets and the error still showed, and only stops showing when i disable the mod, and starts showing again when i re-enable the mod

Expected Behavior

stop showing the error

Install Method

Self-Compiled. Completely vanilla to the 'main' branch except for the config in platformio.ini changes to default_envs, uncommented line to the onewire lib,

and added:

-D USERMOD_DALLASTEMPERATURE
-D USERMOD_INTERNAL_TEMPERATURE
-D USERMOD_PWM_FAN

under [env:esp32c3dev]

What version of WLED?

0.15.0

Which microcontroller/board are you seeing the problem on?

ESP32-C3

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[lost-hope]

What preset is set in the dialog field in the setting of the internal temp preset?

[orbitinstasis]

What preset is set in the dialog field in the setting of the internal temp preset?

0

[lost-hope]

Try setting that to -1

[blazoncek]

0 should be a valid value and should mean "no preset" as no presets can have id 0.

[orbitinstasis]

Just did a small but reasonable boundary test.

If i set the 'preset to set' value to -1 and click save, it changes automatically back to 0. Same behaviour on the polling setting if you go anything below 10000.

I always get th error if the setting is 0 for the preset, and also occurs if the number is a positive integer higher than any preset I have saved.

However, the error never shows if the preset to set is an integer above 0 which I also have a saved preset for

[lost-hope]

OK i will look into it later. Maybe tomorrow. i havent added the preset functionality to the usermod, but normally it should not try to change the preset when set to 0. (atleast that is what a quick look showed)

[orbitinstasis]

OK i will look into it later. Maybe tomorrow. i havent added the preset functionality to the usermod, but normally it should not try to change the preset when set to 0. (atleast that is what a quick look showed)

I might be understanding the intended use wrongly. It being a safety feature (with the default temp being in the upper quadrant of the operating temps) I assumed it'd turn the LEDs off, but if I am supposed to plug in my own valid preset then I'll get on and make an 'all leds off' preset.

Essentially, not sure if the default value 0 is supposed to be overwritten.

Either way, thanks for looking into it.

[lost-hope]

Found the issue and made a PR.

[orbitinstasis]

Found the issue and made a PR.

Thanks - when might this move to the main branch ? I'm assuming that's the branch the devs want most users who are compiling usermods to use?