Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install python files in lib #572

Merged
merged 13 commits into from
Oct 14, 2019
Merged

Install python files in lib #572

merged 13 commits into from
Oct 14, 2019

Conversation

petricm
Copy link

@petricm petricm commented Oct 3, 2019 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • Install python files in lib/pythonX.Y/site-packages resolves Python installation location #562
    • adapt thisdd4hep.sh scripts
  • Add missing RPATH to examples (basically bug fix for mac)
  • Add DDG4 tools to bin to make them more accessible to users:
    • g4MaterialScan, checkGeometry, checkOverlaps

ENDRELEASENOTES

@petricm petricm added the cleanup label Oct 3, 2019
andresailer
andresailer reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csh scripts were anyway not working?

DDCore/CMakeLists.txt Outdated Show resolved Hide resolved
@petricm
Copy link
Author

petricm commented Oct 11, 2019

As for the csh, it was really old (nobody touched it for 6 years) and it differs functionally form the sh

@petricm petricm merged commit 6ec388f into AIDASoft:master Oct 14, 2019
@petricm petricm mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

Assignees
No one assigned
Labels
cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python installation location
2 participants
@petricm @andresailer