Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't receive offer status update when provision smart wallet dialog dismissed #119

Closed
samsiegart opened this issue Jan 6, 2025 · 0 comments · Fixed by #120
Closed

Don't receive offer status update when provision smart wallet dialog dismissed #119

samsiegart opened this issue Jan 6, 2025 · 0 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@samsiegart
Copy link
Contributor

When using @agoric/react-components, the makeOffer function from useAgoric() will show a dialog when the user doesn't have a smart wallet provisioned. If the user clicks proceed in the dialog, the offer will be executed. However, if the user dismisses the dialog, the status update callback never gets invoked, so the caller has no way of knowing that the offer was aborted. It should send an error status update in this case. This will allow the app to show a loading indicator or something like that, and stop showing it if the dialog is dismissed rather than the user clicking "proceed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant