Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgReturnGrants returns the wrong Type #8719

Closed
JimLarson opened this issue Jan 8, 2024 · 1 comment · Fixed by #8791
Closed

MsgReturnGrants returns the wrong Type #8719

JimLarson opened this issue Jan 8, 2024 · 1 comment · Fixed by #8791
Assignees
@JimLarson
Labels
agoric-cosmos bug Something isn't working

Comments

@JimLarson
Copy link
Contributor

Describe the bug

In agoric-labs/cosmos-sdk/x/auth/vesting/types/msgs.go, MsgReturnGrants.Type() returns TypeMsgClawback instead of TypeMsgReturnGrants.

Impact is bad simulation of the command leading to a bad gas estimate.

To Reproduce

See code.

Expected behavior

See Description.

Platform Environment

All.
@JimLarson JimLarson added bug Something isn't working agoric-cosmos labels Jan 8, 2024
@JimLarson JimLarson self-assigned this Jan 8, 2024
This was referenced Jan 31, 2024
Merged
Merged
@mergify mergify bot closed this as completed in #8791 Feb 6, 2024
@JimLarson
Copy link
Contributor Author

Verified upgrade-14 by source inspection.

@JimLarson JimLarson changed the title MsgClawback returns the wrong Type MsgReturnGrants returns the wrong Type Mar 19, 2024
@coderabbitai coderabbitai bot mentioned this issue Apr 18, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimLarson JimLarson

Labels
agoric-cosmos bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upgrade interchain stack to ibc5 Agoric/agoric-sdk
1 participant
@JimLarson