Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report heap snapshot size delta #10910

Open
mhofman opened this issue Jan 29, 2025 · 0 comments
Open

Report heap snapshot size delta #10910

mhofman opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request telemetry

Comments

@mhofman
Copy link
Member

mhofman commented Jan 29, 2025

What is the Problem Being Solved?

One of the metric we're interested in is the growth of xsnap worker heap snapshots. While we currently report the uncompressed size of snapshots in heap-snapshot-save slog events, it's sometimes difficult to observe the growth rate: a previous snapshot save event is not always available in the same execution. At least one heap-snapshot-load event should be present and contain the uncompressedSize, but that means we'd now have 2 different kind of events to observe

Description of the Design

Remember the uncompressedSize in RAM when loading a snapshot, and compute the uncompressedSizeDelta when saving the snapshot, and report with the other metrics. When making a snapshot after start/upgrade, the delta would be null.

Security Considerations

None

Scaling Considerations

None

Test Plan

Verify new field presence in slog events

Upgrade Considerations

None

@mhofman mhofman added the enhancement New feature or request label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry
Projects
None yet
Development

No branches or pull requests

2 participants