Fix: Getting incorrect max frequency value #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where epp cannot be set in `powersave` governor (AdnanHodzic#738)
|
Closing this for now, as of yesterday I started getting mixed results, will investigate futher to see what's actually going on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (partially) closes #737. Instead of getting the max frequency from
cpuinfo_max_freq, it gets fromscaling_max_freq. It shoudn't be a problem for most systems, since these values tend to be the same. However, on some cases(like #737), they are reported different, with thescaling_max_freqbeing the correct one. Apparently this can happen if turbo boost is enabled by means other than the bios , like writing to the cpu registers directly or editing/sys/devices/system/cpu/intel_pstate/no_turboAny feedback about potential problems or improvements would be greatly appreciated.