Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended CSS rules aren't re-evaluated on attribute change #77

Closed
ameshkov opened this issue Dec 25, 2018 · 2 comments
Closed

Extended CSS rules aren't re-evaluated on attribute change #77

ameshkov opened this issue Dec 25, 2018 · 2 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Dec 25, 2018

Here is the test case:
http://ameshkov.github.io/web/watchattr.html

Here is the relevant discussion:
uBlockOrigin/uBlock-issues#341

Important comments there:

@krystian3w
Copy link

krystian3w commented Sep 1, 2019

Maybe same bug: 4kdownload.com

4kdownload.com##body[style^="padding-right"]:has(.remodal-wrapper #ouibounce-modal.is-opened) .remodal-overlay

4kdownload.com##body[style^="padding-right"]:has(.remodal-wrapper .thanks-modal.remodal-is-opened) .remodal-overlay

I try remove overlay activated only by pop-up newsletter / thanks for download pop-up. No if pop-up has video promotion from vimeo.

From observation, the .is-opened / .remodal-is-opened class is not active at the same time (so not: badly closed newsletter or thank you that should be at network level or scriptlet inactivated).


There is a chance that in 2023 the site generates pop-ups differently, hence the filter should be tested in some archive service (e.g. web.archive.org?) what a little damaged JavaScript actions or adjust to the modifications recently made on it (when further there is a video "vimeo" in the pop-up and separately a newsletter/thank you download also in the same pop-up).

@ameshkov
Copy link
Member Author

@zzebrum I've already opened a new one: #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants